Building permits slicing + measurements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladyslav-tk
force-pushed
the
building_permits_slicing
branch
from
ad7304c to
ebb33d8
Compare
vladyslav-tk
changed the title
vladyslav-tk
force-pushed
the
building_permits_slicing
branch
from
fcc4bc5 to
8e9a494
Compare
gberaudo
approved these changes
Jan 8, 2025
|
|
||
| renderSceneIfTranslucent(): void { | ||
| // because calling render decreases performance, only call it when needed. | ||
| // see https://cesium.com/docs/cesiumjs-ref-doc/Scene.html#pickTranslucentDepth |
There was a problem hiding this comment.
pickTranslucentDepth is false by default.
Can you explain what you mean?
There was a problem hiding this comment.
I moved it from NGM, we will need it if we want to draw on a map when it semi transparent
| renderSceneIfTranslucent(): void { | ||
| // because calling render decreases performance, only call it when needed. | ||
| // see https://cesium.com/docs/cesiumjs-ref-doc/Scene.html#pickTranslucentDepth | ||
| if (this.viewer_.scene.globe.translucency.enabled) { |
There was a problem hiding this comment.
no but maybe in future
src/plugins/cesium/draw.ts
Outdated
| if (this.eventHandler_) { | ||
| this.eventHandler_.destroy(); | ||
| } | ||
| this.eventHandler_ = undefined; |
vladyslav-tk
force-pushed
the
building_permits_slicing
branch
from
8e9a494 to
205eb1a
Compare
vladyslav-tk
force-pushed
the
building_permits_slicing
branch
from
205eb1a to
993e3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.