Added support of IFC upload #26

vladyslav-tk · 2025-01-13T15:26:39Z

No description provided.

gberaudo · 2025-01-14T08:40:35Z

src/plugins/cesium/ngv-plugin-cesium-upload.ts

+    }
+
+    const decoder = new TextDecoder('utf-8');
+    const text = decoder.decode(arrayBuffer);


Suggested change

const text = decoder.decode(arrayBuffer);

const text = decoder.decode(arrayBuffer.slice(0, 15);

gberaudo · 2025-01-14T08:53:47Z

src/plugins/cesium/ngv-plugin-cesium-upload.ts

+    }
+
+    const decoder = new TextDecoder('utf-8');
+    const text = decoder.decode(arrayBuffer);


Also, what happens when the loaded file is binary?
I guess the decode will fail.

I tested, it works

gberaudo · 2025-01-14T08:55:05Z

src/plugins/cesium/ngv-plugin-cesium-upload.ts

+
+    const decoder = new TextDecoder('utf-8');
+    const text = decoder.decode(arrayBuffer);
+    const isIfc = text.includes('ISO-10303-21');


Should it be startsWith?

vladyslav-tk requested a review from gberaudo January 13, 2025 15:26

gberaudo approved these changes Jan 14, 2025

View reviewed changes

gberaudo reviewed Jan 14, 2025

View reviewed changes

Added support of IFC upload

1e4e931

vladyslav-tk force-pushed the ifc_upload branch from 6ceeeb4 to 1e4e931 Compare January 14, 2025 13:16

vladyslav-tk merged commit 40c2c61 into master Jan 14, 2025
2 checks passed

Provide feedback

	const text = decoder.decode(arrayBuffer);
	const text = decoder.decode(arrayBuffer.slice(0, 15);