Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw in destructor of ManagerBase during stack unwinding #6107

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

gassmoeller
Copy link
Member

Noticed while working on #6097. If we throw an exception while parsing the parameters of the manager class the size of plugin_names and plugin_objects may not be the same. But if we throw an exception during the stack unwinding the program crashes without helpful error message. So only throw if during a regular destruction the size does not match.

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, that's a wild failure mode!

@bangerth bangerth merged commit 528b304 into geodynamics:main Oct 23, 2024
8 checks passed
@gassmoeller gassmoeller deleted the improve_manager_base branch October 25, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants