Enable deprecation warnings when building and in user plugins #6115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
force-pushed
the
enable_deprecation_warnings
branch
from
70f4ab2 to
4f4f60c
Compare
tjhei
approved these changes
Oct 28, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6106. Independent of whether we decide to enable these warnings in deal.II again, I think it would be a good idea to have them enabled for ASPECT. Otherwise our users do not notice if their plugins use deprecated features (this will likely already cause confusion because some of the deprecated features I removed in #6083 and #6084 may not have emitted any warnings with deal.II 9.5 or 9.6).