Add Hillshade layer to notebook api #304
Draft
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Integration tests report: appsharing.space |
gjmooney
force-pushed
the
change_tests
branch
from
415e153 to
7c1f656
Compare
martinRenou
reviewed
Jan 10, 2025
| "attribution": { | ||
| "type": "string", | ||
| "description": "The attribution for the raster-dem source" | ||
| }, | ||
| "encoding": { |
There was a problem hiding this comment.
Is it some outdated thing we used to have with maplibre?
There was a problem hiding this comment.
Yea, that and tileSize were needed in MapLibre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
add_hillshade_layerto notebook api and removes some old MapLibre stuff from theRasterDemSourceschema.Checklist
Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--304.org.readthedocs.build/en/304/
💡 JupyterLite preview is available from the doc, by clicking on