feat: use DualCurrency input field (#35) #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deviated a bit from the screenshot of #35 to make the implementation of #44 easier. Another reason is that the displayed value in USD is only the current equivalent, in the future it might have a different value of course, so I expressed that accordingly.
I could not find any tests, so I have not added any for this new feature as introducing all of the testing infrastructure would be out of scope of this PR. But I'm happy to add them once testing is in place.
Two more things, when running locally I got the following error:
Another problem was that I had to change the
serveHost
inpages/api/inngest.ts
to "http://localhost:8081" for it to run locally. But since these issues are unrelated to this PR I did not touch them. Just FYI