feat: use token events to subscribe to the token changes #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
bumi
reviewed
Oct 24, 2023
rolznz
reviewed
Nov 2, 2023
rolznz
reviewed
Nov 2, 2023
rolznz
reviewed
Nov 2, 2023
rolznz
reviewed
Nov 4, 2023
| @@ -254,11 +254,22 @@ export default class Alby implements Connector { | |||
| token: this.config.oAuthToken, // initialize with existing token | |||
| }); | |||
|
|
|||
| //// Currently the JS SDK guarantees request of a new refresh token is done synchronously. | |||
There was a problem hiding this comment.
I think this comment is in the wrong place
Can you put it in the authClient.on("tokenRefreshFailed") function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
listen for token changes via alby-js-sdk events
Type of change
(Remove other not matching type)
feat: New feature (non-breaking change which adds functionality)How has this been tested?
trying oauth in extension
Checklist