Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include amount in index #453

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

reneaaron
Copy link
Contributor

Speed up the check_balance() trigger that is being run after every payment.

@bumi
Copy link
Contributor

bumi commented Nov 30, 2023

@reneaaron see the test error. how did we do it with other migrations?

@reneaaron
Copy link
Contributor Author

Interesting, never seen that before. 🤔

Could be related to this:
golang-migrate/migrate#284

I'll give it a try to split up the migration into 2 separate ones.

@reneaaron reneaaron force-pushed the feat/add-transaction-entries-index branch from c8a29d5 to 080360c Compare November 30, 2023 20:14
@reneaaron
Copy link
Contributor Author

@bumi Added bun splits that separate these statements into different transactions. (like it's done in previous migrations, too)

@reneaaron reneaaron requested a review from bumi December 8, 2023 16:25
@reneaaron reneaaron merged commit 2360406 into main Jan 19, 2024
3 checks passed
@reneaaron reneaaron deleted the feat/add-transaction-entries-index branch January 19, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants