Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stucture field: fix preview input when paginated #6894

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Stucture field: fix preview input when paginated #6894

merged 1 commit into from
Jan 13, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 11, 2025 •
edited by bastianallgeier
Loading

Description

Summary of changes

  • When a structure field is paginated, k-table will only receive the slice of values for the current page.
  • Consequently, it will only emit those rows again when a row is updated via a field preview.
  • Thus, we cannot simply save what we receive from he table input event, but need to splice those rows into the full unpaginated array and save that one.

Changelog

Fixes

  • Structure field: fixed losing rows when changes were made through a field preview in a paginated table

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 4.6.0 milestone Jan 11, 2025
@distantnative distantnative self-assigned this Jan 11, 2025
@distantnative distantnative linked an issue Jan 11, 2025 that may be closed by this pull request
[v4] Paginated structure display bug #6892
Closed
@distantnative distantnative requested a review from a team January 11, 2025 12:11
bastianallgeier
bastianallgeier approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about toSpliced 🤯 Nice!

@bastianallgeier bastianallgeier merged commit a1e1ab9 into develop-minor Jan 13, 2025
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/6892-structure-field-paginated-table-input branch January 13, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
critical: roadblock 🚧 Needs to be solved first
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

[v4] Paginated structure display bug
2 participants
@distantnative @bastianallgeier