Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page section w/ table layout: fix flag column #6900

Merged

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 11, 2025

Description

Summary of changes

Reasoning

It's not the prettiest solution, but the most pragmatic to fix the regression right now.

Mid term, it would be good to encapsulate k-table into a k-table-items wrapper component which adds support for buttons entry as individual columns.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 5.0.0-beta.2 milestone Jan 11, 2025
@distantnative distantnative requested a review from a team January 11, 2025 18:11
@distantnative distantnative self-assigned this Jan 11, 2025
@distantnative distantnative linked an issue Jan 11, 2025 that may be closed by this pull request
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quite like it. It's indeed not pretty, but pretty pragmatic :)

@bastianallgeier bastianallgeier merged commit d6c232b into v5/develop Jan 13, 2025
4 checks passed
@bastianallgeier bastianallgeier deleted the v5/fix/6866-page-section-table-layout-flag-btn branch January 13, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[v5] Table layout: page status flag missing
2 participants