Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer: move inline nodes to toolbar inline btns #6902

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 11, 2025

Description

Summary of changes

  • Include all nodes with inline: true not in the toolbar dropdown but as inline button (inserted between dropdown button and first marks button)
  • Refactor k-writer-toolbar to get away more from node/mark naming but rather dropdown/inline
  • Split a bunch of methods and added inline comments to make component easier to read and understand

Changelog

Fixes

  • Custom writer nodes: fixed active state detection for nodes that include paragraph child nodes

Enhancements

  • Writer: nodes with inline: true in their button definition are displayed as inline buttons in toolbar (instead inside the dropdown)
  • New this.$helper.object.filter(object, predicate)

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

@distantnative distantnative added this to the 5.0.0-beta.2 milestone Jan 11, 2025
@distantnative distantnative self-assigned this Jan 11, 2025
@distantnative distantnative force-pushed the v5/enhancement/writer-inline-nodes branch 2 times, most recently from 62b5a4a to 00826cd Compare January 12, 2025 10:05
@distantnative distantnative force-pushed the v5/enhancement/writer-inline-nodes branch from 00826cd to 43fdcde Compare January 12, 2025 10:37
@distantnative distantnative requested a review from a team January 12, 2025 10:39
@distantnative distantnative marked this pull request as ready for review January 12, 2025 10:40
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me and the refactoring also looks good.

@bastianallgeier bastianallgeier merged commit 3bc69f4 into v5/develop Jan 15, 2025
4 checks passed
@bastianallgeier bastianallgeier deleted the v5/enhancement/writer-inline-nodes branch January 15, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants