-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Dependencies: the LOGIC #2940
Shared Dependencies: the LOGIC #2940
Conversation
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
…version Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
…-y curl did not complete successfully Signed-off-by: schristoff <[email protected]>
… cleaned up desperately before debugging Signed-off-by: schristoff <[email protected]>
…ndle manifest Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
… on install and invoke Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I only have documentation nits.
docs/content/docs/development/authoring-a-bundle/working-with-dependencies.md
Outdated
Show resolved
Hide resolved
docs/content/docs/development/authoring-a-bundle/working-with-dependencies.md
Outdated
Show resolved
Hide resolved
docs/content/docs/development/authoring-a-bundle/working-with-dependencies.md
Outdated
Show resolved
Hide resolved
docs/content/docs/development/authoring-a-bundle/working-with-dependencies.md
Outdated
Show resolved
Hide resolved
docs/content/docs/development/authoring-a-bundle/working-with-dependencies.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: schristoff <[email protected]>
…dependencies.md Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: schristoff <[email protected]>
…dependencies.md Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: schristoff <[email protected]>
…dependencies.md Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: schristoff <[email protected]>
…dependencies.md Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: schristoff <[email protected]>
…dependencies.md Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: schristoff <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly documentation feedback. I caught a couple spelling issues. I could have missed others, so might want to run through spellchecker.
Nice work!!
docs/content/docs/development/authoring-a-bundle/working-with-dependencies.md
Outdated
Show resolved
Hide resolved
docs/content/docs/development/authoring-a-bundle/working-with-dependencies.md
Outdated
Show resolved
Hide resolved
docs/content/docs/development/authoring-a-bundle/working-with-dependencies.md
Outdated
Show resolved
Hide resolved
…dependencies.md Co-authored-by: David Justice <[email protected]> Signed-off-by: schristoff <[email protected]>
…dependencies.md Co-authored-by: David Justice <[email protected]> Signed-off-by: schristoff <[email protected]>
…dependencies.md Co-authored-by: David Justice <[email protected]> Signed-off-by: schristoff <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🚀 🦄
Signed-off-by: Sarah Christoff <[email protected]>
Goal: If I have a parent bundle and a dependency, and that dependency already exists, don't install the dependency again, just wire them up together.
Things to note: