-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependcies and update go to 1.21 #2999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troy0820
requested review from
schristoff,
sgettys and
bdegeeter
as code owners
February 14, 2024 16:30
troy0820
force-pushed
the
troy0820/update-deps
branch
from
February 14, 2024 16:38
9f2a56f
to
3fcda7e
Compare
Signed-off-by: Troy Connor <[email protected]>
troy0820
force-pushed
the
troy0820/update-deps
branch
from
February 14, 2024 19:28
83602dd
to
4e50e12
Compare
Signed-off-by: Troy Connor <[email protected]>
troy0820
force-pushed
the
troy0820/update-deps
branch
from
February 14, 2024 21:16
48dd304
to
77344ba
Compare
looks all green, all good to merge? |
Let me check the integration tests, they are not showing up for some reason |
troy0820
force-pushed
the
troy0820/update-deps
branch
from
February 14, 2024 23:07
b60f704
to
77344ba
Compare
Signed-off-by: Troy Connor <[email protected]>
Closed
Do we need the comment for integ now? 😮💨 This workflow is so finnicky lately
|
schristoff
approved these changes
Mar 13, 2024
Thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Update dependencies to a newer version of kubernetes. This change brought in the need to update go to 1.21 which should be okay being that go 1.22 came out.
What issue does it fix
N/A
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist
Reviewer Checklist