Mask sensitive values logged through spans #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes getporter#3216 closes getporter#2256 Signed-off-by: Kim Christensen <[email protected]>
kichristensen
force-pushed
the
tracerLogSensitiveValues
branch
from
1befbac to
776ee5c
Compare
kichristensen
changed the title
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
schristoff
approved these changes
Dec 20, 2024
| func (cw *CensoredWriter) Censor(b []byte) []byte { | ||
| for _, val := range cw.sensitiveValues { | ||
| if strings.TrimSpace(val) != "" { | ||
| b = bytes.Replace(b, []byte(val), []byte("*******"), -1) |
There was a problem hiding this comment.
qq: Should we replace []byte("*******"), with just []byte("**"),, assuming we have a very long sensitive value this can get kind of large, no?
There was a problem hiding this comment.
@schristoff The length of the sensitive value should not matter, as it will always replace the value with *******. This will of course make the log longer if the sensitive value is very short, but otherwise the lenght should not matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Ensure logs written using the tracer won't contain sensitive information.
What issue does it fix
closes #3216
closes #2256
Checklist