Re-enabled integration tests #3306
Open
+273
−317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgannon991
force-pushed
the
feature/3300/enable-integration-tests
branch
4 times, most recently
from
52847e3 to
570d37e
Compare
dgannon991
requested review from
schristoff,
sgettys,
bdegeeter,
troy0820 and
kichristensen
as code owners
| @@ -93,124 +93,39 @@ jobs: | |||
| uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main | |||
| with: | |||
| test_name: telemetry_test | |||
| # Reusable workflows only supports 20 jobs | |||
There was a problem hiding this comment.
Is this no longer the case? It is listed as a limitation on the GitHub documentation page
There was a problem hiding this comment.
I had a quick search and could not find it mentioned, so thought I'd give it a go as a test. It seems to work and run them all! Do you have a link handy for the documentation?
There was a problem hiding this comment.
Sorry forgot to add the link, it is written here, https://docs.github.com/en/actions/sharing-automations/reusing-workflows#limitations
There was a problem hiding this comment.
I think it's saying you can call 20 different re-usable workflows, not the same workflow more than twenty times. It definitely seems to be running all of them correctly.
Signed-off-by: David Gannon <[email protected]>
Signed-off-by: David Gannon <[email protected]>
dgannon991
force-pushed
the
feature/3300/enable-integration-tests
branch
from
ddcd76f to
add344d
Compare
Signed-off-by: David Gannon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Adds back more of the integration tests into the pipeline (they were already running locally)
What issue does it fix
Closes #3300