Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not resolve parameters defined in parameter sets if they are overriden #3309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not resolve parameters defined in parameter sets if they are overriden #3309

wants to merge 1 commit into from

Conversation

kichristensen
Copy link
Contributor

What does this change

  • Add ability to skip parameters from parameter sets when they are overridden
  • Introduce Contains() method to StrategyList to check parameter existence
  • Update ResolveAll interface to accept skipParams
  • Add integration test for parameter override functionality

What issue does it fix

Closes #3308

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

@kichristensen
feat(parameters): add parameter override functionality for parameter …
9c506ad 
…sets

- Add ability to skip parameters from parameter sets when they are overridden
- Introduce Contains() method to StrategyList to check parameter existence
- Update ResolveAll interface to accept skipParams
- Add integration test for parameter override functionality

Signed-off-by: Kim Christensen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff Awaiting requested review from schristoff schristoff is a code owner

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overriding parameters in a parameter set still requires the overriden parameter to be resolvable
1 participant
@kichristensen