This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Fix deadlock on task scheduling when VM start fails #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When VM startup fails, the task is rescheduled and after recent changes to scheduler state management, this structure caused deadlock. Inline task rescheduling to avoid deadlock.
tuommaki
commented
Mar 22, 2024
| @@ -310,7 +310,9 @@ impl Scheduler { | |||
| state.task_queue.remove(&task.tx); | |||
| } | |||
|
|
|||
| self.reschedule(&task).await?; | |||
There was a problem hiding this comment.
self.state is locked here, but fn reschedule() tried to lock it again, in order to push the task back to queue.
musitdev
approved these changes
Mar 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When VM startup fails, the task is rescheduled and after recent changes to scheduler state management, this structure caused deadlock.
Inline task rescheduling to avoid deadlock.