Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Parse json args as vector of strings #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koxu1996
Copy link

Asking for args in key=value format is a mistake, as it is often necessary to pass single values for CLI execution. There was workaround #201, but I believe we should just use a vector of strings. Not only it's simpler and more intuitive, but it also supports weird case when user wants to pass empty string as an argument.

This is breaking change of CLI, but resolves all the issues with passing args. I will update documentation accordingly, once this PR is merged.

This is breaking change of CLI, but resolves all the issues with passing
args.
@koxu1996 koxu1996 requested a review from tuommaki August 28, 2024 10:01
@koxu1996 koxu1996 self-assigned this Aug 28, 2024
@tuommaki
Copy link
Contributor

Asking for args in key=value format is a mistake, as it is often necessary to pass single values for CLI execution.

I 💯 agree with you on this, but I'd rather not merge this in at this point. There's more than our documentation (e.g. blog articles, TG support / examples etc.) with the old format and I don't want to break them at this point when the devnet as-is won't be live too long anymore. We must ensure that the future APIs handle arguments correctly (which they do atm. AFAIK) and just put up with this unfortunate key=value brainfart.

@koxu1996
Copy link
Author

What about supporting both formats and printing deprecation warning when key=value is used?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants