Don't broadcast propagated transaction

[tuommaki]

If transaction has already been propagated (tx.propagated == true), don't send it to P2P network anymore.

[musitdev]

Just one remarks. tx_chan.send_tx(&tx) use p2p broadcast that doesn't fail if one node fail to receive the Tx. It only fails if there's no protocol writing registered.
Do we have to manage a fail when the Tx is send?

[tuommaki]

Just one remarks. tx_chan.send_tx(&tx) use p2p broadcast that doesn't fail if one node fail to receive the Tx. It only fails if there's no protocol writing registered.
Do we have to manage a fail when the Tx is send?

Sounds like it wouldn't be easy in the current setting? It could also be a bit pointless, as there's no "catch-up replication" implemented, where a node would pull missing data if it was offline for a period of time. I'm not really sure if any of these are necessary during the devnet period?

[musitdev]

If the node crash or restart, it should bootstrap from another node to get all missing data. The fact is that an error can occur during sending the Tx without because the distant node has crashed. Some heartbeat should be implemented if not. If the heartbeat fails, the node that has network issue should restart and bootstrap. If the connection issue last less than the heartbeat, the node should resent the tx to avoid restarting both node.