Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test-chat-template.cpp #11224

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Refactor test-chat-template.cpp #11224

merged 2 commits into from
Jan 14, 2025

Conversation

ochafik
Copy link
Collaborator

@ochafik ochafik commented Jan 14, 2025 •
edited
Loading

Brings together the test name, template and expected output

(extracted from #11016 )

@github-actions github-actions bot added the testing Everything test related label Jan 14, 2025
@ochafik ochafik marked this pull request as ready for review January 14, 2025 00:39
@ochafik ochafik requested a review from ngxson January 14, 2025 00:44
@ochafik ochafik mentioned this pull request Jan 14, 2025
Open
3 tasks
@ericcurtin ericcurtin merged commit 091592d into ggerganov:master Jan 14, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcurtin ericcurtin ericcurtin approved these changes

@ngxson ngxson Awaiting requested review from ngxson

Assignees
No one assigned
Labels
testing Everything test related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ochafik @ericcurtin