abort reinitialization #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initializing again might break --toggle. When overlayfs is enabled and a reinitialization is attempted, cmdline.txt.orig will be overwritten with the current cmdline.txt.overlay. (because cmdline.txt equals cmdline.txt.overlay at that point and will be backed up). Additionally 'boot=overlay' will be added a second time to cmdline.txt. Overall it does not seem to be a good idea to reinitialize, therefore such an attempt should be aborted. Signed-off-by: Julian Heuking <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initializing again might break --toggle.
When overlayfs is enabled and a reinitialization is attempted,
cmdline.txt.orig will be overwritten with the current cmdline.txt.overlay.
(because cmdline.txt equals cmdline.txt.overlay at that point and will
be backed up).
Additionally 'boot=overlay' will be added a second time to cmdline.txt.
Overall it does not seem to be a good idea to reinitialize, therefore
such an attempt should be aborted.
Signed-off-by: Julian Heuking [email protected]