-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tag): new component #203
feat(tag): new component #203
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice this is looking good! We'll need the key; the other change is a suggestion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! I added one small code suggestion (I'll probably just add this and merge it!)
Thanks @DeadEnglish this is great 👏 |
What doe this do?
For #125, we need a
Tag
component that will be used to display tags associated to the showcase on display. This is a quick implementation using all the brand & atom colours. Future improvement of aghost
prop (no background colour, just the border) but will look into it if we need it once the page is complete.FWIW there's probably some accessibility issues with the background/text colours but can be fixed later.
Code usage
Images/video