Bug Fix: Fix aria-hidden error #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the fix was applied for screen readers we triggered an error because the container of the terminal interface had a tab index, which it really shouldn't since there's nothing to interact with. I've removed this tab index and also made the quick change to force the various header bar states to not have a toggle on hover since 1. it's a bit distracting and 2. sort of unnecessary. Also it looks like there were some prettier changes that tweaked parts of the file.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the fix was applied for screen readers we triggered an error because the container of the terminal interface had a tab index, which it really shouldn't since there's nothing to interact with.
I've removed this tab index and also made the quick change to force the various header bar states to not have a toggle on hover since 1. it's a bit distracting and 2. sort of unnecessary.
This is what the error looked like:
This also has the nice side effect as a single tab action takes us directly to the download button.
Also it looks like there were some prettier changes that tweaked parts of the file.