Add wayland-protocols to required dependencies #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated the install commands for Arch and Debian/Ubuntu. Debian: https://packages.debian.org/search?keywords=wayland-protocols Ubuntu: https://launchpad.net/ubuntu/+source/wayland-protocols Arch: https://archlinux.org/packages/extra/any/wayland-protocols/
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gpanders
commented
Jan 7, 2025
| * `pkg-config` | ||
| * `wayland-protocols` (unless using `-Dgtk-wayland=false`) |
There was a problem hiding this comment.
I think this should be true, but this build option currently doesn't work when I tested it:
$ zig build -Dgtk-wayland=false
...
src/apprt/gtk/wayland.zig:3:25: error: no module named 'wayland' available within module root
const wayland = @import("wayland");
We only add the root module in build.zig when gtk-wayland is true, but it's then used unconditionally (cc @pluiedev).
There was a problem hiding this comment.
We should fix that, for now I'll merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the install commands for Arch and Debian/Ubuntu.
Debian: https://packages.debian.org/search?keywords=wayland-protocols
Ubuntu: https://launchpad.net/ubuntu/+source/wayland-protocols
Arch: https://archlinux.org/packages/extra/any/wayland-protocols/