Skip to content

Commit

Permalink
add --allow-shlib-undefined in link options
Browse files Browse the repository at this point in the history
  • Loading branch information
yhmtsai committed Nov 10, 2024
1 parent d196b56 commit 102fa65
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/msys.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ jobs:
run: |
If (Test-Path "C:\_") { rm -r -fo "C:\_" }
Copy-Item -Path ".\temp" -Destination "C:\_" -Recurse
- name: Debug over SSH (tmate)
uses: mxschmitt/[email protected]
# - name: Debug over SSH (tmate)
# uses: mxschmitt/[email protected]
- name: CI-Build
shell: msys2 {0}
id: build
Expand All @@ -83,8 +83,8 @@ jobs:
unset VCPKG_ROOT
mkdir build
cd build
cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DGINKGO_BUILD_HWLOC=OFF -DGINKGO_BUILD_EXAMPLES=OFF -DGINKGO_BUILD_TESTS=OFF -DGINKGO_BUILD_BENCHMARKS=OFF -DCMAKE_CXX_FLAGS="-Wl,--allow-shlib-undefined" ..
cmake --build --verbose .
cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DGINKGO_BUILD_HWLOC=OFF -DGINKGO_BUILD_EXAMPLES=OFF -DGINKGO_BUILD_TESTS=OFF -DGINKGO_BUILD_BENCHMARKS=OFF ..
cmake --build . --verbose
- name: "Clean up runner"
if: ${{ always() }}
Expand Down
1 change: 1 addition & 0 deletions cmake/build_helpers.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ function(ginkgo_compile_features name)
if (GINKGO_CHECK_CIRCULAR_DEPS)
target_link_libraries("${name}" PRIVATE "${GINKGO_CIRCULAR_DEPS_FLAGS}")
endif()
target_link_options("${name}" PRIVATE "--allow-shlib-undefined")

set_target_properties("${name}" PROPERTIES POSITION_INDEPENDENT_CODE ON)
endfunction()
Expand Down

0 comments on commit 102fa65

Please sign in to comment.