add it into shared_library_create flag

ginkgo-project · Nov 7, 2024 · f9bc805 · f9bc805
1 parent 98d2ba7
commit f9bc805
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.github/workflows/msys.yml b/.github/workflows/msys.yml
@@ -81,7 +81,7 @@ jobs:
           unset VCPKG_ROOT
           mkdir build
           cd build
-          cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DGINKGO_BUILD_HWLOC=OFF -DGINKGO_BUILD_EXAMPLES=OFF -DGINKGO_BUILD_TESTS=OFF -DGINKGO_BUILD_BENCHMARKS=OFF -DCMAKE_CXX_FLAGS="-undefined dynamic_lookup" ..
+          cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DGINKGO_BUILD_HWLOC=OFF -DGINKGO_BUILD_EXAMPLES=OFF -DGINKGO_BUILD_TESTS=OFF -DGINKGO_BUILD_BENCHMARKS=OFF ..
           ninja
 
       - name: "Clean up runner"

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -272,6 +272,9 @@ if(MSVC)
     else()
         set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS FALSE)
     endif()
+    if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
+        set(CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS "${CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS} -undefined dynamic_lookup")
+    endif()
 endif()
 
 if(GINKGO_BUILD_SYCL)