Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump year to 2025 #1760

Merged
merged 3 commits into from
Jan 8, 2025
Merged

bump year to 2025 #1760

merged 3 commits into from
Jan 8, 2025

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Jan 2, 2025 •
edited
Loading

This PR bumps the year to 2025 in LICENSE, and some minor fixes : end-of-file and fillin in typo

@yhmtsai yhmtsai added 1:ST:ready-for-review This PR is ready for review 1:ST:skip-full-test 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Jan 2, 2025
@yhmtsai yhmtsai requested a review from a team January 2, 2025 06:16
@yhmtsai yhmtsai self-assigned this Jan 2, 2025
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:testing This is related to testing. reg:ci-cd This is related to the continuous integration system. reg:documentation This is related to documentation. reg:example This is related to the examples. reg:benchmarking This is related to benchmarking. type:solver This is related to the solvers type:preconditioner This is related to the preconditioners type:matrix-format This is related to the Matrix formats type:factorization This is related to the Factorizations type:reordering This is related to the matrix(LinOp) reordering reg:helper-scripts This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo. type:multigrid This is related to multigrid type:stopping-criteria This is related to the stopping criteria mod:all This touches all Ginkgo modules. labels Jan 2, 2025
@yhmtsai yhmtsai force-pushed the happy_new_year_2025 branch from f44bd99 to 037aca5 Compare January 3, 2025 03:09
@upsj
Copy link
Member

upsj commented Jan 3, 2025

With the year being set automatically, do we need to keep doing this, or is it enough to update files when we change them? Might lead to fewer rebases required around the new year?

@MarcelKoch
Copy link
Member

I would agree with @upsj. It's probably enough to update the LICENSE file. Everything else can just be updated when we actually change the file.

@yhmtsai yhmtsai force-pushed the happy_new_year_2025 branch from 037aca5 to f132fb1 Compare January 7, 2025 08:22
@yhmtsai yhmtsai requested review from upsj and MarcelKoch January 8, 2025 07:39
@yhmtsai
Copy link
Member Author

yhmtsai commented Jan 8, 2025

@upsj @MarcelKoch I update year in LICENSE + apply end-of-file fix for all files + and some typo stuff

@yhmtsai yhmtsai merged commit 7286f30 into develop Jan 8, 2025
10 of 11 checks passed
@yhmtsai yhmtsai deleted the happy_new_year_2025 branch January 8, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@pratikvn pratikvn pratikvn approved these changes

@upsj upsj upsj approved these changes

Assignees

@yhmtsai yhmtsai

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-for-review This PR is ready for review 1:ST:skip-full-test mod:all This touches all Ginkgo modules. reg:benchmarking This is related to benchmarking. reg:build This is related to the build system. reg:ci-cd This is related to the continuous integration system. reg:documentation This is related to documentation. reg:example This is related to the examples. reg:helper-scripts This issue/PR is related to the helper scripts mainly concerned with development of Ginkgo. reg:testing This is related to testing. type:factorization This is related to the Factorizations type:matrix-format This is related to the Matrix formats type:multigrid This is related to multigrid type:preconditioner This is related to the preconditioners type:reordering This is related to the matrix(LinOp) reordering type:solver This is related to the solvers type:stopping-criteria This is related to the stopping criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yhmtsai @upsj @MarcelKoch @pratikvn @ginkgo-bot