-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query method implementations #3
Open
psy2848048
wants to merge
7
commits into
feat/bip39
Choose a base branch
from
feat/query
base: feat/bip39
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psy2848048
requested review from
jhlee-young,
JoowonYun,
tlguszz10,
mj-delightlabs and
jaeminDelightlabs
December 12, 2024 13:18
Comment on lines
438
to
448
do { | ||
let res: R = try await http.request( | ||
httpMethod: http.HttpMethod.post, | ||
url: URL.init(string: self.host)!, | ||
params: data | ||
)! | ||
|
||
return res | ||
} catch let err { | ||
throw err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than unwrapping, it might be better to maintain type safety and handle values explicitly using optional binding.
Suggested change
do { | |
let res: R = try await http.request( | |
httpMethod: http.HttpMethod.post, | |
url: URL.init(string: self.host)!, | |
params: data | |
)! | |
return res | |
} catch let err { | |
throw err | |
} | |
guard let url = URL.init(string: self.host) else { | |
throw http.APIError.invalidURL | |
} | |
do { | |
guard let res: R = try await http.request( | |
httpMethod: http.HttpMethod.post, | |
url: url, | |
params: data | |
) else{ | |
// Unexpected data format | |
throw http.APIError.cannotParseRequest | |
} | |
return res; | |
} catch let err { | |
throw err | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
psy2848048
force-pushed
the
feat/bip39
branch
from
December 21, 2024 09:06
640c70f
to
645ffb1
Compare
psy2848048
force-pushed
the
feat/query
branch
from
December 21, 2024 09:06
e5802b0
to
13659f6
Compare
psy2848048
force-pushed
the
feat/bip39
branch
from
December 23, 2024 02:20
645ffb1
to
4643721
Compare
psy2848048
force-pushed
the
feat/query
branch
from
December 23, 2024 02:21
13659f6
to
54ec752
Compare
JoowonYun
approved these changes
Dec 23, 2024
psy2848048
force-pushed
the
feat/bip39
branch
from
December 23, 2024 07:31
4643721
to
aaeba93
Compare
psy2848048
force-pushed
the
feat/query
branch
from
December 23, 2024 07:31
b039247
to
1c541ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XrplClient.swift
BaseMethod.swift
-> Protocol and its BaseRequest