Merge pull request #797 from rak3-sh/rp/fix-796

Fix #796 (A13-3-1) - Consider reporting overloaded functions that are at different locations.
github · Nov 26, 2024 · 813b416 · 813b416
2 parents 5c5bb64 + 56d886e
commit 813b416
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/change_notes/2024-11-13-fix-fp-796.md b/change_notes/2024-11-13-fix-fp-796.md
@@ -0,0 +1,2 @@
+ - `A13-3-1` - `FunctionThatContainsForwardingReferenceAsItsArgumentOverloaded.ql`:
+   - Reduce false positives by explicitly checking that the locations of overloaded functions are different.
diff --git a/...tosar/src/rules/A13-3-1/FunctionThatContainsForwardingReferenceAsItsArgumentOverloaded.ql b/...tosar/src/rules/A13-3-1/FunctionThatContainsForwardingReferenceAsItsArgumentOverloaded.ql
@@ -14,6 +14,7 @@
 
 import cpp
 import codingstandards.cpp.autosar
+import codingstandards.cpp.FunctionEquivalence
 
 class Candidate extends TemplateFunction {
   Candidate() {
@@ -29,6 +30,8 @@ where
     OperatorsPackage::functionThatContainsForwardingReferenceAsItsArgumentOverloadedQuery()) and
   not f.isDeleted() and
   f = c.getAnOverload() and
+  // Ensure the functions are not equivalent to each other (refer #796).
+  not f = getAnEquivalentFunction(c) and
   // allow for overloading with different number of parameters, because there is no
   // confusion on what function will be called.
   f.getNumberOfParameters() = c.getNumberOfParameters() and
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		- `A13-3-1` - `FunctionThatContainsForwardingReferenceAsItsArgumentOverloaded.ql`:
		- Reduce false positives by explicitly checking that the locations of overloaded functions are different.