Java: Update JAX-RS annotation inheritance #18137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
changed the title
owen-mc
force-pushed
the
java/jax-rs-annotation-inheritance
branch
from
0944ae3 to
12c6f87
Compare
owen-mc
changed the title
owen-mc
force-pushed
the
java/jax-rs-annotation-inheritance
branch
from
12c6f87 to
9cc614a
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- java/ql/lib/semmle/code/java/frameworks/JaxWS.qll: Language not supported
- java/ql/test/library-tests/frameworks/JaxWs/JakartaRs1.java: Evaluated as low risk
- java/ql/test/library-tests/frameworks/JaxWs/JakartaRs3.java: Evaluated as low risk
- java/ql/test/library-tests/frameworks/JaxWs/JaxRs1.java: Evaluated as low risk
Comments suppressed due to low confidence (5)
java/ql/test/library-tests/frameworks/JaxWs/JakartaRs4.java:58
- The @OverRide annotation is repeated. Remove the duplicate annotation.
@Override
java/ql/test/library-tests/frameworks/JaxWs/JaxRsInterface.java:27
- The comment should be updated to: 'This annotation has no effect according to the JAX-RS specification, as class/interface annotations are not inherited.'
@Path("/resource") // This annotation has no effect, as class/interface annotations are not inherited in jax-rs
java/ql/test/library-tests/frameworks/JaxWs/JaxRs4.java:63
- The @path annotation with an empty string is unusual and might be a mistake. Consider providing a meaningful path or removing the annotation.
@Path("")
java/ql/test/library-tests/frameworks/JaxWs/JaxRs3.java:34
- The parameter name for @QueryParam is empty. It should be renamed to a meaningful parameter name.
@QueryParam("")
java/ql/test/library-tests/frameworks/JaxWs/JaxRs3.java:67
- The parameter name for @QueryParam is empty. It should be renamed to a meaningful parameter name.
@QueryParam("")
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
owen-mc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currrently, our JAX-RS models correctly follow the spec, which says that annotations on classes and interfaces aren't inherited. However, some implementations (like Apache CXF), do allow inheritance of annotations on classes and interfaces. This PR updates our modeling to allow inheritance of those annotations (but only when the class does not have any JAX-RS annotations).
This PR also adds lots of tests.