Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Remove potential FPs from cpp/integer-multiplication-cast-to-long in BMN #18580

Closed
wants to merge 2 commits into from

Conversation

calumgrant
Copy link
Contributor

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions bot added the C++ label Jan 23, 2025
@calumgrant calumgrant force-pushed the calumgrant/bmn/int-multiplication branch from 6e44efb to 60076dc Compare January 23, 2025 19:46
@calumgrant
Copy link
Contributor Author

Having reviewed the DCA results, it looks like all of the results lost are "good" results, and this query simply loses too many results. As a result, the approach used by this query isn't the right way forward.

@calumgrant calumgrant closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant