Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for open source #212

Merged
merged 10 commits into from
Jun 11, 2020
Merged

Update README for open source #212

merged 10 commits into from
Jun 11, 2020

Conversation

brianamarie
Copy link
Contributor

This pull request updates the README with information requested via #202.

cc @githubtraining/programs @githubtraining/implementation-engineers @amyschoen for 👀

@brianamarie brianamarie self-assigned this May 12, 2020
@brianamarie brianamarie mentioned this pull request May 12, 2020
32 tasks
amyschoen
amyschoen previously approved these changes May 12, 2020
Copy link
Collaborator

@amyschoen amyschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@brianamarie
Copy link
Contributor Author

Thank you so much @amyschoen and @parkerbxyz!

@parkerbxyz, I've incorporated the suggested edits and am currently working with the linter. How does this version look to you?

@parkerbxyz
Copy link
Contributor

parkerbxyz commented May 20, 2020

I think the linter failing has something to do with #191 being merged into master yesterday. I'll merge master into this branch to see if that fixes things.

@parkerbxyz
Copy link
Contributor

parkerbxyz commented May 20, 2020

Yep, that did the trick! 🙂

@brianamarie
Copy link
Contributor Author

Thank you so much, @parkerbxyz! Do you mind taking another look to see if there are any more changes needed, or approve if you think it looks ok?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@brianamarie brianamarie merged commit 1733bc4 into master Jun 11, 2020
@brianamarie brianamarie deleted the update-readme branch June 11, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants