Add Azure DevOps integration #20202

mustard-mh · 2024-09-11T18:47:49Z

Description

Doc https://github.com/gitpod-io/website/pull/4858
/hold, revert 189c431

Related Issue(s)

How to test

It can setup an Azure DevOps integration
‼️ there should have only one DevOps integration in an installation because providers are uniq by host. There's only one org in Gitpod Enterprise, so it should be safe there. In preview env, it's working because of utils.ts changes

Join my org https://hw-tt-azure.preview.gitpod-dev.com/orgs/join?inviteId=62450a0e-2f5c-4956-a8d7-a97a00bc3ddc
Ask @mustard-mh to update you as an admin
Then you can delete and re-activate Azure DevOps integration by yourself again

Test with Git Integration

Context are proper parsed on workspace creation page (not found? not authenticated?)
Workspaces are created with proper context
It can push to remote repository

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

🏷️ Name - hw-tt-azure
🔗 URL - hw-tt-azure.preview.gitpod-dev.com/workspaces.
📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
📦 Version - hw-tt-azure-gha.28758
🗒️ Logs - GCP Logs Explorer

Build Options

Build

/werft with-werft
Run the build with werft instead of GHA
leeway-no-cache
/werft no-test
Run Leeway with --dont-test

Publish

/werft publish-to-npm
/werft publish-to-jb-marketplace

Installer

analytics=segment
with-dedicated-emulation
workspace-feature-flags
Add desired feature flags to the end of the line above, space separated

Preview Environment / Integration Tests

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-gce-vm
If enabled this will create the environment on GCE infra
/werft preemptible
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
with-monitoring

/hold

components/dashboard/src/data/auth-providers/create-user-auth-provider-mutation.ts

components/gitpod-protocol/src/protocol.ts

components/public-api/buf.gen.yaml

geropl · 2024-09-16T07:30:24Z

Awesome work @mustard-mh ! 🧡
Did not test (yet), but this looks really complete already. 🏁
Have a great week off, and see you next week 👋

components/dashboard/src/teams/git-integrations/GitIntegrationModal.tsx

components/dashboard/src/data/auth-providers/update-org-auth-provider-mutation.ts

components/server/src/azure-devops/azure-context-parser.ts

…settings page

socket-security · 2024-09-26T20:59:33Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	environment, filesystem Transitive: eval, network	`+3`	6.86 MB	edergachev

View full report↗︎

filiptronicek

leaving some initial comments, will do another round before approving

components/dashboard/src/data/auth-providers/update-org-auth-provider-mutation.ts

components/dashboard/src/data/auth-providers/update-user-auth-provider-mutation.ts

components/server/src/dev/dev-data.ts

filiptronicek · 2024-09-27T09:46:50Z

components/server/src/azure-devops/azure-token-validator.ts

+            found = true;
+            isPrivateRepo = true;
+            writeAccessToRepo = true;


Could be useful to add a comment about why we can make these assumptions. I know that it has to be private, but am not for instance sure about the write access one.

There's no API to check if user has write permission on a repo. We assume user has write permission so that we don't show git permission missing on user push.

If write permission is actually missed, user can find it out from git commands error output

filiptronicek · 2024-09-27T09:53:28Z

components/server/src/azure-devops/azure-repository-provider.ts

+    }
+
+    async getUserRepos(user: User): Promise<RepositoryInfo[]> {
+        // FIXME(janx): Not implemented yet


nit: poor @jankeromnes!

Suggested change

// FIXME(janx): Not implemented yet

// todo(hw): Not implemented yet

filiptronicek · 2024-09-27T09:56:08Z

components/server/src/azure-devops/azure-repository-provider.ts

+        return result
+            .slice(1)
+            .map((c) => c.commitId)
+            .filter((c) => !!c) as string[];


nit: we could get rid of the type assertion by upgrading typescript

components/server/src/azure-devops/azure-context-parser.ts

components/server/src/azure-devops/azure-context-parser.spec.ts

components/public-api/typescript-common/src/auth-providers.ts

components/server/src/azure-devops/README.md

Co-authored-by: Filip Troníček <[email protected]>

filiptronicek · 2024-09-27T14:35:57Z

@mustard-mh I wonder if there's something easy we can do on the integrations page WRT the Azure DevOps endpoint: I am not sure if we are at all compatible with DevOps server, but depending on that it'd be great to either nudge / restrict the endpoint to dev.azure.com

- dashboard provider type update - doc for checkWriteAccess - Requirement.DEFAULT

This reverts commit 189c431.

filiptronicek

Let's get this Friday evening shipped 🚀

Incredible work, Huiwen!

mustard-mh · 2024-09-27T17:15:29Z

/unhold

roboquat added do-not-merge/hold do-not-merge/work-in-progress size/L size/XXL and removed size/L labels Sep 11, 2024

mustard-mh changed the title ~~WIP WIP~~ WIP: Add Azure DevOps integration Sep 13, 2024

geropl reviewed Sep 16, 2024

View reviewed changes

components/dashboard/src/data/auth-providers/create-user-auth-provider-mutation.ts Show resolved Hide resolved

geropl reviewed Sep 16, 2024

View reviewed changes

components/gitpod-protocol/src/protocol.ts Show resolved Hide resolved

geropl reviewed Sep 16, 2024

View reviewed changes

components/public-api/buf.gen.yaml Outdated Show resolved Hide resolved

filiptronicek reviewed Sep 18, 2024

View reviewed changes

components/dashboard/src/teams/git-integrations/GitIntegrationModal.tsx Show resolved Hide resolved

components/dashboard/src/data/auth-providers/update-org-auth-provider-mutation.ts Outdated Show resolved Hide resolved

filiptronicek mentioned this pull request Sep 25, 2024

Azure DevOps support gitpod-io/browser-extension#157

Merged

filiptronicek reviewed Sep 25, 2024

View reviewed changes

components/server/src/azure-devops/azure-context-parser.ts Show resolved Hide resolved

mustard-mh and others added 17 commits September 26, 2024 10:22

Add node package

a14f259

first nit changes

ae5fd77

nit proto udpate

fe82871

fixup

11b738f

[server] add azure support

11d18a8

fixup

31939b8

fixup

f22d0a3

server fixup

6ca56e4

[dashboard] changes

fadcb32

fixup

4bcaa90

fixup

de778be

Fix server bugs

f4b6b74

Fixup

393ff4e

Fix dashboard

b33e0ca

Fix user integration

262eb92

Fix permission update modal

fd55a59

tmp

86450c5

dashboard: add comments and remove new Azure DevOps supports on user …

4d5d4f0

…settings page

Fix push warning and make project a part of owner

f33d5a3

mustard-mh force-pushed the hw/tt-azure branch from b70b83c to f33d5a3 Compare September 26, 2024 21:16

mustard-mh added 2 commits September 26, 2024 22:07

Proper handle errors

bae8f0a

Fix token can't refresh issue

87afe7f

mustard-mh changed the title ~~WIP: Add Azure DevOps integration~~ Add Azure DevOps integration Sep 27, 2024

mustard-mh marked this pull request as ready for review September 27, 2024 07:50

mustard-mh requested review from a team as code owners September 27, 2024 07:50

roboquat removed the do-not-merge/work-in-progress label Sep 27, 2024

github-actions bot added team: team-experience team: team-enterprise labels Sep 27, 2024

mustard-mh requested a review from filiptronicek September 27, 2024 07:55

mustard-mh added 2 commits September 27, 2024 09:22

Fix api

8a0e87f

Add project context supports

e621899

filiptronicek reviewed Sep 27, 2024

View reviewed changes

Update components/server/src/azure-devops/azure-context-parser.spec.ts

ce12d3d

Co-authored-by: Filip Troníček <[email protected]>

mustard-mh added 6 commits September 27, 2024 15:25

Fix readablestream error

ac749a4

Fix clone url

be43556

Address feedback

d5ff0f3

- dashboard provider type update - doc for checkWriteAccess - Requirement.DEFAULT

1

0314a7d

avatar

2ac4ecd

Revert "revert me"

d7f086d

This reverts commit 189c431.

filiptronicek approved these changes Sep 27, 2024

View reviewed changes

roboquat removed the do-not-merge/hold label Sep 27, 2024

roboquat merged commit 41f47c8 into main Sep 27, 2024
28 of 29 checks passed

roboquat deleted the hw/tt-azure branch September 27, 2024 17:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Azure DevOps integration #20202

Add Azure DevOps integration #20202

mustard-mh commented Sep 11, 2024 •

edited

Loading

geropl commented Sep 16, 2024

socket-security bot commented Sep 26, 2024 •

edited

Loading

filiptronicek left a comment

filiptronicek Sep 27, 2024

mustard-mh Sep 27, 2024

filiptronicek Sep 27, 2024

mustard-mh Sep 27, 2024

filiptronicek Sep 27, 2024

filiptronicek commented Sep 27, 2024

filiptronicek left a comment

mustard-mh commented Sep 27, 2024

	// FIXME(janx): Not implemented yet
	// todo(hw): Not implemented yet

Add Azure DevOps integration #20202

Add Azure DevOps integration #20202

Conversation

mustard-mh commented Sep 11, 2024 • edited Loading

Description

Related Issue(s)

How to test

Documentation

Preview status

Build Options

geropl commented Sep 16, 2024

socket-security bot commented Sep 26, 2024 • edited Loading

filiptronicek left a comment

Choose a reason for hiding this comment

filiptronicek Sep 27, 2024

Choose a reason for hiding this comment

mustard-mh Sep 27, 2024

Choose a reason for hiding this comment

filiptronicek Sep 27, 2024

Choose a reason for hiding this comment

mustard-mh Sep 27, 2024

Choose a reason for hiding this comment

filiptronicek Sep 27, 2024

Choose a reason for hiding this comment

filiptronicek commented Sep 27, 2024

filiptronicek left a comment

Choose a reason for hiding this comment

mustard-mh commented Sep 27, 2024

mustard-mh commented Sep 11, 2024 •

edited

Loading

socket-security bot commented Sep 26, 2024 •

edited

Loading