Added poetry for setup and workflow #5
Conversation
…p. Updated build to be completely through poetry and simplified pre-commit.
|
Hey it looks like the PR was removed for some reason. But sounds good, I made it solely poetry based and also added that to the workflow as well so it would be compatible. I also bumped the version to |
| [tool.poetry.dependencies] | ||
| python = "^3.9" | ||
|
|
||
| numpy = ">=1.0.1" |
There was a problem hiding this comment.
nit: can you add this in alphabetical order
| [tool.poetry.dependencies] | ||
| python = "^3.9" | ||
|
|
||
| numpy = ">=1.0.1" |
There was a problem hiding this comment.
see if you require the cython requirement (new requirements.txt file) . w/o it I had trouble with scipy CI/CD tests passing; if it passes w/o cython requirement as-is, feel free to drop that requirement
There was a problem hiding this comment.
Ok I tried it with and without that requirement and it seems the CI/CD pipeline passes in both cases. I'll leave it out for now, and if it becomes a problem later you can always add it in.
No description provided.