Fix compiler warnings #693
Conversation
| @@ -188,6 +188,7 @@ void option_list::parse(int argc, char** argv) | |||
| } catch (std::exception& exc) { | |||
| throw std::exception(); | |||
| }; | |||
| break; | |||
There was a problem hiding this comment.
The fall-through here was a bug; it caused a blank line to be printed if the -R, -j, or -p options were used with volk_profile.
| switch (help_line.size() / 8) { | ||
| case 0: | ||
| help_line += "\t"; | ||
| case 1: | ||
| help_line += "\t"; | ||
| case 2: | ||
| help_line += "\t"; | ||
| case 3: | ||
| help_line += "\t"; |
There was a problem hiding this comment.
This code is just meant to line up the tables that are displayed by volk_profile --help and volk_config-info --help. The new version gets rid of the fall-through warnings, and is simpler.
| (void)input; | ||
|
|
There was a problem hiding this comment.
It's intentional that input is unused, so I added (void)input to suppress the unused parameter warnings.
There was a problem hiding this comment.
C23 provides something for this exact situation:
maybe_unused
I suggest to add a comment to the (void)input; lines because this will make it more verbose. Otherwise, someone may remove these lines in the future because the look superfluous.
There was a problem hiding this comment.
as to give a differing opinion: (void)input; is the canonical way of silencing this warning and thus of marking a variable as unused. It's as concise as it gets! (and pretty unambiguous; if there's a (void)input; in the code, and you are about to remove it, you would reasonably ask yourself why it is in the code, and stackoverflow has you covered.
There was a problem hiding this comment.
(also, the goal here would be to enable -Werror -Wunused-parameter so that a removal of that line would become a build fail)
Signed-off-by: Clayton Smith <[email protected]>
argilo
force-pushed
the
compile-warnings
branch
from
06afa9d to
b900da1
Compare
Fix compiler warnings
When building with
-DCMAKE_BUILD_TYPE=ASANa number of compiler warnings are shown. I've cleaned up most of them here.