Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method that tells the app/backend that we are using a dark mode theme #326

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gcasa
Copy link
Member

@gcasa gcasa commented Jan 5, 2025

The purpose of this PR is to add a method to make the system aware that a theme using "dark mode" is being used. This will assist in settings for editors and, particularly, with printing.

@rmottola
Copy link
Member

A discussed via voice, I think we need two properties:

  • Theme "is dark". When switched system issues dark mode notification and identifies as darkmode.
  • Theme supports both light and dark modes

The latter porperty is for future work, non need to implement it now.

isDarkMode in this context is a little bit ambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants