better max_allowed_packet parsing

[methane]

Description

Remove stringToInt() and use strconv.Atoi instead.

Checklist

• Code compiles correctly
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary
• Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling for max_allowed_packet configuration conversion
  • Enhanced error reporting when invalid integer values are encountered

• Refactor

  • Replaced custom string-to-integer conversion with standard library method
  • Removed custom conversion utility function

[coderabbitai]

Walkthrough

The pull request introduces changes to error handling in the connector.go file, specifically for converting the max_allowed_packet configuration value. The stringToInt function from utils.go has been removed, and the conversion is now done using strconv.Atoi with more explicit error handling. This modification improves the clarity of error reporting when parsing integer configuration values, ensuring more robust handling of invalid inputs.

Changes

File	Change Summary
connector.go	- Added fmt package import - Replaced custom string-to-int conversion with strconv.Atoi - Enhanced error handling for max_allowed_packet conversion
utils.go	- Removed stringToInt function

Possibly related PRs

• small code cleanup #1598: Improvements to error handling in the query method of the mysqlConn struct

Suggested reviewers

• shogo82148

Poem

🐰 A Rabbit's Ode to Error Handling 🔍

In bytes and strings, a conversion dance,
With strconv.Atoi, we take our chance
No more custom tricks, just clear and bright
Errors now speak with wisdom's might
A cleaner path through code's domain

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7403860 and 13e1379.

📒 Files selected for processing (2)

• connector.go (2 hunks)
• utils.go (0 hunks)

💤 Files with no reviewable changes (1)

• utils.go

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: test (windows-latest, 1.23, mariadb-10.5)
• GitHub Check: test (windows-latest, 1.23, mariadb-10.6)
• GitHub Check: test (windows-latest, 1.23, mariadb-10.11)
• GitHub Check: test (windows-latest, 1.23, mariadb-11.4)
• GitHub Check: test (windows-latest, 1.23, 9.0)

🔇 Additional comments (3)

connector.go (3)

14-14: LGTM!

The fmt package import is correctly added and necessary for improved error formatting.

---

183-188: Great improvements to error handling!

The changes effectively:

1. Replace custom implementation with standard library's strconv.Atoi
2. Enhance error reporting by including the invalid value in the message
3. Follow Go best practices for error handling

---

183-188: Verify complete removal of stringToInt.

Let's ensure that stringToInt is not used elsewhere in the codebase.

✅ Verification successful

Verified: stringToInt has been completely removed

The function has been successfully removed from utils.go and no other instances of similar string-to-int conversion patterns were found in the codebase. The change is complete and consistent.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining usage of stringToInt
rg "stringToInt"

# Search for any direct integer parsing of system variables that might benefit from similar improvements
ast-grep --pattern 'getSystemVar($_)'

Length of output: 56

---

Script:

#!/bin/bash
# Check if utils.go exists and contains stringToInt
fd utils.go --exec cat {}

# Look for similar string-to-int conversion patterns
ast-grep --pattern 'strconv.Atoi(string($_))'

Length of output: 20968

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

coverage: 83.158% (+0.02%) from 83.141%
when pulling 13e1379 on methane:max-allowed-packet-parsing
into 7403860 on go-sql-driver:master.

[shogo82148]

LGTM