-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v1.9.0 #1662
base: master
Are you sure you want to change the base?
release v1.9.0 #1662
Conversation
WalkthroughThis pull request updates the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (10)
🔇 Additional comments (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
20-20
: Consider consistent PR reference formatting.For better readability, consider using a consistent format for multiple PR references. You could either:
- Use the same hyperlink format as older entries:
[#1595](url), [#1601](url), [#1641](url)
- Or keep the current format but add spaces after commas:
(#1595, #1601, #1641)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.5)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.6)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.11)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.1)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.2)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.4)
- GitHub Check: test (windows-latest, 1.23, 5.7)
- GitHub Check: test (windows-latest, 1.23, 8.0)
- GitHub Check: test (windows-latest, 1.23, 8.4)
- GitHub Check: test (windows-latest, 1.23, 9.0)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.5)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.6)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.11)
- GitHub Check: test (macos-latest, 1.23, mariadb-11.4)
- GitHub Check: test (macos-latest, 1.23, 9.0)
🔇 Additional comments (2)
CHANGELOG.md (2)
9-9
: Verify MySQL 9.0 reference.MySQL 9.0 hasn't been released yet. Consider clarifying if this is for a preview/beta version or if the version number needs to be corrected.
1-22
: Well-structured changelog entry.The changelog entry is well-organized, properly categorized, and follows the project's established format. All changes are tracked with PR references, making it easy to find detailed information about each change.
Description
Update changelog.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Improvements
max_allowed_packet
parsing