sources/scim: fix user creation (duplicate userName) #12547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BeryJu
approved these changes
Jan 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12547 +/- ##
==========================================
+ Coverage 92.69% 92.78% +0.08%
==========================================
Files 770 769 -1
Lines 38873 38879 +6
==========================================
+ Hits 36033 36073 +40
+ Misses 2840 2806 -34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens Langhammer <[email protected]>
mahmoudajawad
pushed a commit
to mahmoudajawad/authentik
that referenced
this pull request
Jan 15, 2025
* sources/scim: fix user creation (duplicate userName) * sources/scim: add test case (duplicate username) * Formatting * simplify query with Q Signed-off-by: Jens Langhammer <[email protected]> --------- Signed-off-by: Jens Langhammer <[email protected]> Co-authored-by: Jens Langhammer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
According to the SCIM standard both
idanduserNamemust be unique.The current behaviour only rejects duplicate
ids, and this PR fixes it.A new test case has been added:
test_user_create_duplicate_by_username, and run.Results from https://scimvalidator.microsoft.com/ have been saved and replayed for local testing.
Checklist
sudo poetry run python -m manage test authentik/sources/scim/tests/test_users.py)make lint-fix)