Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/authenticator_email: Email OTP #12630

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

melizeche
Copy link

@melizeche melizeche commented Jan 10, 2025

Details

[Work in Progress] Add email authenticator stage # 3291


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@melizeche melizeche requested a review from a team as a code owner January 10, 2025 09:10
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 9856492
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6780ec903ef9310008400e20

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 9856492
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6780ec900f146b0008aa634c

@rissson rissson marked this pull request as draft January 10, 2025 17:24
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 41.69611% with 165 lines in your changes missing coverage. Please review.

Project coverage is 49.74%. Comparing base (5eaa949) to head (9856492).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
authentik/stages/authenticator_email/tasks.py 0.00% 61 Missing ⚠️
authentik/stages/authenticator_email/stage.py 36.14% 53 Missing ⚠️
authentik/stages/authenticator_email/tests.py 0.00% 42 Missing ⚠️
authentik/stages/authenticator_email/models.py 85.00% 9 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5eaa949) and HEAD (9856492). Click for more details.

HEAD has 17 uploads less than BASE
Flag BASE (5eaa949) HEAD (9856492)
e2e 19 10
unit 6 0
integration 3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12630       +/-   ##
===========================================
- Coverage   92.70%   49.74%   -42.96%     
===========================================
  Files         769      773        +4     
  Lines       38840    38860       +20     
===========================================
- Hits        36007    19332    -16675     
- Misses       2833    19528    +16695     
Flag Coverage Δ
e2e 48.52% <41.69%> (+0.02%) ⬆️
integration 24.66% <28.62%> (+0.02%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson changed the title [DRAFT] stages/authenticator_email: Email OTP stages/authenticator_email: Email OTP Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant