web: Improve form input validation and visibility. #12812
+268
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
GirlBossRush
commented
Jan 25, 2025
| class="pf-c-form-control pf-m-monospace" | ||
| autocomplete="off" | ||
| spellcheck="false" | ||
| inputmode="url" |
There was a problem hiding this comment.
Opted for inputmode over setting the type to "url". This will hint to the browser that a URL-oriented virtual keyboard is preferred without requiring a valid protocol prefixing the domain.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12812 +/- ##
==========================================
- Coverage 92.75% 92.70% -0.06%
==========================================
Files 769 769
Lines 38926 38926
==========================================
- Hits 36107 36087 -20
- Misses 2819 2839 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR addresses feedback regarding the visibility of code-like input fields where character differentiation is needed, e.g. tokens, URLs, usernames, protocol arguments.
Additionally, these same input fields no longer trigger browser spell-check or autocomplete, reducing visual noise when completing a form.
Before
After
Before
After
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)