The argument to "test -n" must be quoted, otherwise we get a bogus

"true" response to the test.
gobolinux · Mar 26, 2017 · 605f44c · 605f44c
1 parent 647bf16
commit 605f44c
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/Functions/Compile b/Functions/Compile
@@ -39,10 +39,8 @@ function Verify_Files() {
    local sums=($3)
    local use_sha=($4)
    if [ $use_sha == 1 ]
-   then
-      Get_Sum="Get_SHA"
-   else
-      Get_Sum="Get_MD5"
+   then Get_Sum="Get_SHA"
+   else Get_Sum="Get_MD5"
    fi
    for i in $(seq 0 $[${#myfiles[@]}-1])
    do
@@ -312,11 +310,9 @@ function do_fetch() {
          }
       else
          # Use sha checksum if available
-         if [ -n ${file_shas} ];
-         then
-            Verify_Files "${files[*]}" "${file_sizes[*]}" "${file_shas[*]}" 1
-         else
-            Verify_Files "${files[*]}" "${file_sizes[*]}" "${file_md5s[*]}" 0
+         if [ -n "${file_shas}" ];
+         then Verify_Files "${files[*]}" "${file_sizes[*]}" "${file_shas[*]}" 1
+         else Verify_Files "${files[*]}" "${file_sizes[*]}" "${file_md5s[*]}" 0
          fi
          result=$?
          case $result in