Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AgX tonemapping using old approach in Compatibility rendering method #101365

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 9, 2025

Its implementation now matches the one used in RenderingDevice-based rendering methods.

Not cherry-pickable to 4.3, as AgX is only in 4.4.

Its implementation now matches the one used in RenderingDevice-based
rendering methods.
@Calinou Calinou requested a review from a team as a code owner January 9, 2025 19:59
@Calinou Calinou added this to the 4.4 milestone Jan 9, 2025
Copy link
Contributor

@allenwp allenwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new code matches the rendering device shader. Results look as expected to me. AgX (and ACES for that matter) is not designed to work gamma space input, so I expect results to not necessarily look "good" in all cases. Here are some comparisons using Compatibility:

master AgX this PR AgX ACES
image image image
image image image
image image image
image image image
image image image

@Calinou
Copy link
Member Author

Calinou commented Jan 10, 2025

AgX (and ACES for that matter) is not designed to work gamma space input, so I expect results to not necessarily look "good" in all cases.

I've empirically found I can get a better result by decreasing the Tonemap Exposure property to a value around 0.5, but it depends on the scene.

@akien-mga akien-mga merged commit e4a12a0 into godotengine:master Jan 10, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the agx-compatibility-use-rd-approach branch January 10, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants