Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logically separet srpm macros and add example specfiles #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jcajka
Copy link
Collaborator

@jcajka jcajka commented Mar 28, 2018

No description provided.

@jcajka jcajka changed the title Logically separet srpm macros Logically separet srpm macros and example specfiles Mar 28, 2018
@jcajka jcajka changed the title Logically separet srpm macros and example specfiles Logically separet srpm macros and add example specfiles Mar 28, 2018
@ingvagabund
Copy link
Contributor

@nim-nim WDYT?

@nim-nim
Copy link

nim-nim commented Mar 28, 2018

I mostly think the "separate srpm" bit is wrong as the source layout mirrors the rpm directory tree which does not include any "srpm" directory

As for the spec examples they won't work, better to have a working spec in Fedora that can serve as example than a broken example in the project source and a broken spec in Fedora

You have working packages and specs that are complete enough to work and boostrap even on el7 without any manual intervention there:

https://copr.fedorainfracloud.org/coprs/nim/More_Go_Packaging/package/go-srpm-macros/
https://copr.fedorainfracloud.org/coprs/nim/More_Go_Packaging/package/go-macros/
https://copr.fedorainfracloud.org/coprs/nim/More_Go_Packaging/package/golang-symbols-extractor/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants