-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full spanish harbor ui translation #21369
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sergio Méndez <[email protected]>
My last commit of the year a full Spanish translation for the UI @OrlinVasilev @Vad1mo |
@sergioarmgpl Thank you for your contribution! Since most of the maintainers are not native Spanish speakers, do you have any resources or recommendations that could help us review this PR? That would be very helpful. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21369 +/- ##
==========================================
+ Coverage 45.36% 46.16% +0.79%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6409 +360
- Misses 6983 7136 +153
- Partials 301 338 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
@wy65701436 I am a native speaker 😀 |
Maybe I can find someone that can double check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have enough knowledge to review all the words.
Just one minor comment.
"OIDC_USER_CLAIM": "The name of the claim in the ID Token where the username is retrieved from. If not specified, it will default to 'name'", | ||
"NEW_SECRET": "The secret must longer than 8 chars with at least 1 uppercase letter, 1 lowercase letter and 1 number." | ||
"OIDC_AUTOONBOARD": "Omita la pantalla de incorporación, por lo que el usuario no puede cambiar su nombre de username. El username se proporciona a partir del ID Token", | ||
"OIDC_USER_CLAIM": "El nombre del reclamo en el ID Token de donde se obtiene el username. Si no se especifica, se utilizará de forma predeterminada a 'nombre'.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the last 'nombre' -> 'name', because here the "name" is the claim in the token, which is a key in a JSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I will fix this
Thank you for contributing to Harbor!
Comprehensive Summary of your change
This PR fully translates es-es-lang.json into Spanish language, the current file, is not fully translated. This one includes all the menus and messages into Spanish. This file should be used to translate the Harbor UI into Spanish.
Issue being fixed
Fixes #20976
Please indicate you've done the following: