Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full spanish harbor ui translation #21369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sergioarmgpl
Copy link

@sergioarmgpl sergioarmgpl commented Dec 31, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

This PR fully translates es-es-lang.json into Spanish language, the current file, is not fully translated. This one includes all the menus and messages into Spanish. This file should be used to translate the Harbor UI into Spanish.

Issue being fixed

Fixes #20976

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@sergioarmgpl
Copy link
Author

My last commit of the year a full Spanish translation for the UI @OrlinVasilev @Vad1mo

@wy65701436 wy65701436 added area/i18n Related to Translation changes. help wanted The issues that is valid but needs help from community labels Jan 2, 2025
@wy65701436
Copy link
Contributor

@sergioarmgpl Thank you for your contribution! Since most of the maintainers are not native Spanish speakers, do you have any resources or recommendations that could help us review this PR? That would be very helpful.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (c8c11b4) to head (bc4fa98).
Report is 346 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21369      +/-   ##
==========================================
+ Coverage   45.36%   46.16%   +0.79%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6409     +360     
- Misses       6983     7136     +153     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.16% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@sergioarmgpl
Copy link
Author

@wy65701436 I am a native speaker 😀

@sergioarmgpl
Copy link
Author

Maybe I can find someone that can double check it

Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have enough knowledge to review all the words.
Just one minor comment.

"OIDC_USER_CLAIM": "The name of the claim in the ID Token where the username is retrieved from. If not specified, it will default to 'name'",
"NEW_SECRET": "The secret must longer than 8 chars with at least 1 uppercase letter, 1 lowercase letter and 1 number."
"OIDC_AUTOONBOARD": "Omita la pantalla de incorporación, por lo que el usuario no puede cambiar su nombre de username. El username se proporciona a partir del ID Token",
"OIDC_USER_CLAIM": "El nombre del reclamo en el ID Token de donde se obtiene el username. Si no se especifica, se utilizará de forma predeterminada a 'nombre'.",
Copy link
Contributor

@reasonerjt reasonerjt Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last 'nombre' -> 'name', because here the "name" is the claim in the token, which is a key in a JSON.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I will fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/i18n Related to Translation changes. help wanted The issues that is valid but needs help from community release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanish translation Incomplete in the UI
6 participants