-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ollama_model.py #107
Conversation
there will be an error if using `response.response` ``` AttributeError: 'dict' object has no attribute 'response' ``` As a result, change `response.response` to `response['response']`
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Looks like you need to agree to the CLA which was probably sent to you by email |
Thanks! I just agreed to the CLA : ) |
-- 91b4ad2 by Dennis-yxchen <[email protected]>: Update ollama_model.py there will be an error if using `response.response` ``` AttributeError: 'dict' object has no attribute 'response' ``` As a result, change `response.response` to `response['response']` COPYBARA_INTEGRATE_REVIEW=#107 from Dennis-yxchen:patch-1 91b4ad2 PiperOrigin-RevId: 697596831 Change-Id: Ie48fbd274f17555fd7965f60ff7ef84852baff43
We have approved it on our end, are you able to click a button to merge it now? The system doesn't seem to allow me to do it myself. |
Looks like this got merged somehow by magic? Here it is: 9dd73cc So it looks like it all worked, but somehow got detached from this pull request itself. Very weird. I'll go ahead and close this one now. Let me know if there are any issues and feel free to re-open. |
there will be an error if using
response.response
As a result, change
response.response
toresponse['response']