-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore flaky UI Test, for now (see #1482, fixes #2197) #2203
Ignore flaky UI Test, for now (see #1482, fixes #2197) #2203
Conversation
...ir/datacapture/test/views/QuestionnaireItemDialogMultiSelectViewHolderFactoryEspressoTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay... i thought i sent this out: but my main comment here is can you try to ignore this only for api level 24? this is not flaky on api level 33.
I have no idea if it's possible to (easily) do that. @omarismail94 would you happen to know? If it's not, my recommendation is to ignore it for all, until fixed, to have green CI. |
In the flaky test, you can add this block:
https://junit.org/junit4/javadoc/4.13/org/junit/Assume.html#assumeTrue(boolean) |
An alternative suggested by @jingtang10 is https://developer.android.com/reference/androidx/test/filters/SdkSuppress. |
1ed5737
to
72a5eb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vorburger can you also add the same thing to:
clickAddAnotherAnswer_shouldScrollDownToShowAddAnotherAnswer
It is the other flaky test this library
72a5eb0
to
e390537
Compare
…ctViewHolderFactoryEspressoTest
Fixes #2197, see also #1482
Description
This disables a known flaky UI test. This reduces confusion on why PRs fail to build.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
The alternative is to fix the flaky UI test. My Android foo isn't strong enough to know how to do that, unfortunately.
Type
Choose one: Bug fix
Feature | Documentation | Testing | Code health | Builds | Releases | Other