Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codespace with chown /opt/android workaround (fixes #2614) #2640

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

vorburger
Copy link
Member

Fixes #2614

Description

This fixes #2614.

It works around akhildevelops/devcontainer-features#9.

Alternative(s) considered

Wait for akhildevelops/devcontainer-features#9 and then bump 0.0.2 to 0.0.3.

But no need, this works great - I've tested it.

Type
Choose one: Bug fix Feature | Documentation | Testing | Code health | Builds | Releases | Other

Copy link
Contributor

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vorburger vorburger enabled auto-merge (squash) July 26, 2024 13:25
@jingtang10
Copy link
Collaborator

thanks michael for this

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.76%. Comparing base (9bd76c8) to head (a5fc4be).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2640   +/-   ##
=========================================
  Coverage     65.76%   65.76%           
  Complexity     1057     1057           
=========================================
  Files           197      197           
  Lines          8763     8763           
  Branches       1583     1583           
=========================================
  Hits           5763     5763           
  Misses         2342     2342           
  Partials        658      658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vorburger vorburger merged commit 535b8a3 into master Jul 26, 2024
8 checks passed
@vorburger vorburger deleted the issue-2614_chown branch July 26, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
3 participants