-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resolver.mapToJvmClassName() for KSClassDeclaration #1338
Open
bubenheimer
wants to merge
2
commits into
google:main
Choose a base branch
from
bubenheimer:mapToJvmClassName
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
test-utils/src/main/kotlin/com/google/devtools/ksp/processor/MapJvmClassNameProcessor.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Copyright 2020 Google LLC | ||
* Copyright 2010-2020 JetBrains s.r.o. and Kotlin Programming Language contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.devtools.ksp.processor | ||
|
||
import com.google.devtools.ksp.KspExperimental | ||
import com.google.devtools.ksp.getClassDeclarationByName | ||
import com.google.devtools.ksp.processing.Resolver | ||
import com.google.devtools.ksp.symbol.KSAnnotated | ||
|
||
@KspExperimental | ||
class MapJvmClassNameProcessor : AbstractTestProcessor() { | ||
private val result = mutableListOf<String>() | ||
|
||
override fun toResult(): List<String> { | ||
return result | ||
} | ||
|
||
override fun process(resolver: Resolver): List<KSAnnotated> { | ||
listOf( | ||
"Cls1", | ||
"Cls1.Cls2", | ||
"Cls1.Cls3", | ||
"Cls1.Cls4", | ||
"JavaInterfaceWithVoid", | ||
"JavaClass1", | ||
"JavaClass1.JavaClass2", | ||
"JavaClass1.JavaClass3", | ||
"JavaClass1.JavaClass4", | ||
"JavaClass5", | ||
"JavaAnno", | ||
) | ||
.map { className -> | ||
resolver.getClassDeclarationByName(className)!! | ||
}.forEach { subject -> | ||
result.add(resolver.mapToJvmClassName(subject)!!) | ||
} | ||
return emptyList() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Copyright 2020 Google LLC | ||
* Copyright 2010-2020 JetBrains s.r.o. and Kotlin Programming Language contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
// TEST PROCESSOR: MapJvmClassNameProcessor | ||
// EXPECTED: | ||
// Cls1 | ||
// Cls1$Cls2 | ||
// Cls1$Cls3 | ||
// Cls1$Cls4 | ||
// JavaInterfaceWithVoid | ||
// JavaClass1 | ||
// JavaClass1$JavaClass2 | ||
// JavaClass1$JavaClass3 | ||
// JavaClass1$JavaClass4 | ||
// JavaClass5 | ||
// JavaAnno | ||
// END | ||
|
||
// FILE: Cls1.kt | ||
class Cls1 { | ||
class Cls2 | ||
|
||
open class Cls3 | ||
|
||
inner class Cls4 | ||
} | ||
|
||
// FILE: JavaInterfaceWithVoid.java | ||
interface JavaInterfaceWithVoid {} | ||
|
||
// FILE: JavaClass1.java | ||
class JavaClass1 { | ||
static final class JavaClass2 {} | ||
static class JavaClass3 {} | ||
class JavaClass4 {} | ||
} | ||
|
||
class JavaClass5 {} | ||
|
||
// FILE: JavaAnno.java | ||
@interface JavaAnno {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any more complicated class names? It looks to me that if only nested class matters, we can actually write this in a format of extension function by recursively checking the parent declaration and build a name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used signatureMapper.kt (and MapSignatureProcessor) as a template, for the equivalent Resolver.mapToJvmSignature() functionality. Both tests are equally underpowered. However, I don't think can really do much right now to make my test a lot more expressive until #1335 is fixed, which crashes the new Resolver.mapToJvmClassName() in the same manner, so I expect that a fix for #1335 will similarly clear the landscape here.
Once the fix is in place, I'd think the following additional tests will be particularly useful:
Anything else of particular interest that you can think of?
Edit: also: local class inside top level function (public & internal) in file annotated with @file:JvmName("xyz"). Is that possible within the current test infrastructure?
Edit: inline classes & local class in function with inline class parameter (may have special mangling)