Update: process monitor events all at once upon commit #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignatella
changed the title
patryk4815
reviewed
Oct 23, 2024
stapelberg
requested changes
Oct 23, 2024
|
cc @singchia who contributed the monitoring code |
stapelberg
requested changes
Nov 4, 2024
|
Also added ProcComm check to |
patryk4815
reviewed
Nov 4, 2024
stapelberg
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
While using nftables, we discovered it would be more efficient to process monitor events (changes) all at once upon commit, triggered by the event that caused the change, such as NFT_MSG_NEWGEN.
This PR modifies the way events are handled by grouping all changes together and processing them in response to the event that initiated the change. Additionally, the event header, which includes important information such as the PID, is now propagated. This allows us to identify the process responsible for the change.